שאלות תרגיל בית 1

ערעור על החלק הרטוב

ערעור על החלק הרטוב

על ידי ג'וש אייזקסון בתאריך
מספר תגובות: 1

The test server failed to compile part A of the HW1 wet portion.We downloaded our HW1 resubmission from the resubmission web page and proceeded to run the final check on the csl3 server and it successfully compiled and passed all the tests in the final check..

 

Hi, 

 

My partner and I are taking the mtm course. We sent in HW1 on time but didn’t pass the final check in its entirety before sending in the homework due to several bugs. We received the grade 27.

 

Our submission folder included two identical files by the name of List. List is a module which we used in order to implement two other modules, Map and Election, which we used for part A and part B of the wet portion of the homework.  We decided to attach this module twice in our submission: in the mtm-map folder (containing our Map module files) and in the parent folder (containing our Election module files). We thought that the test server might compile HW1 wet part A separately from part B which would thus lead to missing files (List.cpp). Meaning that if a test for HW1 wet part A (Map) would run only the files inside mtm_map, our code would compile due to the inclusion of our List module files, and vice versa regarding any Election tests. 

 

Upon returning to HW1 in order to fix it for resubmission we realized that we had allocated a pointer in the function mapGet of the Map module. We did so in order to allow us to return a pointer in the function electionGetTribeName, because we used our Map module in our Election module. By fixing this mistake we managed to pass the entire final check with zero errors. In addition to passing the final check, we had also managed to pass a complex test a student had posted in a mtm whatsapp group. 

 

Last friday, after receiving the grade 37 for HW1 (specifically 21 in the wet portion of the homework), we were left confused. After looking at the return-file-test-results we realized that our Map module which we had used for our Election module failed to build/compile. After digging further, we noticed that this was due to us sending in 2 copies of our List module. 

 

Before resubmitting our work, we verified that our zip-submission-file successfully passed the final check. Additionally, we also checked today if the resubmission folder we sent in managed to compile and pass the final check, which it did. The compilation process of the test server differs from that of the final check and that is the reason why we failed all the tests of part A. We request that our work be compiled in the same way as the final check or in a way that doesn’t result in us automatically failing all the part A tests due to our code failing to build. 

 

Thank you for your time,

 

Josh and Sergey 

בתגובה ל: ג'וש אייזקסון

תשובה ל: ערעור על החלק הרטוב

על ידי אורטל כהן בתאריך
Hey,

The final check is one of the requests that you needed to pass, but you also needed to pass the following command (as requested in the pdf file of the exercise - you can see it on page 14):
gcc -std=c99 -o map -Wall -pedantic-errors -Werror -DNDEBUG tests/map_example_test.c mtm_map/*.c *.c

When I tried to run the command with your solution, it failed because of the duplication of list.c in the main folder and the mtm_map folder.
So you could have found the problem before the resubmission.

Have a nice day!